Python: module for import time flow#14617
Merged
yoff merged 6 commits intogithub:mainfrom Nov 2, 2023
Merged
Conversation
The logic for separating local flow into _import time_ and _runtime_ was duplicated a few times. Create a module for it instead, and add a good qldoc.
The logic for adding flow out of post-update-nodes was also duplicated, so I added a module for that also. The two modules are now only used together. I did not fuse them, though, as I think they may not be used together in the case of use-use-flow.
efa3b58 to
1f8a51c
Compare
tausbn
requested changes
Oct 30, 2023
Contributor
tausbn
left a comment
There was a problem hiding this comment.
Generally looks good to me. I have added a few comments here and there. 🙂
Co-authored-by: Taus <tausbn@github.com>
tausbn
approved these changes
Nov 1, 2023
Contributor
tausbn
left a comment
There was a problem hiding this comment.
Thanks for the changes! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic for separating local flow into import time and runtime was duplicated a few times.
Create a module for it instead, and add a good qldoc.
The logic for adding flow out of post-update-nodes
was also duplicated, so I added a module for that also.
The two modules are now only used together (except in one test file).
I did not fuse them, though, as I think they may not be used
together in the case of use-use-flow.